requesting-code-review

软件研发 Superpowers 工程流程 请求评审 2 文件 EN 原文

怎么发起一次有效的评审

把改动整理成别人能快速看懂的形式再请人评审,降低沟通成本。

说明语言:中文

原文描述EN

Use when completing tasks, implementing major features, or before merging to verify work meets requirements

来源obrasuperpowers ↗ 查看原文件 ↗版权归原作者,请遵循原仓库许可
安装
npx skills add https://github.com/obra/superpowers --skill requesting-code-review

需要已安装 skills CLI。也可以直接从源仓库 clone。

在星云中查看 ↗
SKILL.md 原文

name: requesting-code-review description: Use when completing tasks, implementing major features, or before merging to verify work meets requirements ---

Requesting Code Review

Dispatch a code reviewer subagent to catch issues before they cascade. The reviewer gets precisely crafted context for evaluation — never your session's history.

Core principle: Review early, review often.

When to Request Review

Mandatory:

Optional but valuable:

How to Request

1. Get git SHAs:

BASE_SHA=$(git rev-parse HEAD~1)  # or: git merge-base origin/main HEAD
HEAD_SHA=$(git rev-parse HEAD)

2. Dispatch code reviewer subagent:

Dispatch a general-purpose subagent, filling the template at code-reviewer.md

Placeholders:

3. Act on feedback:

Example

[Just completed Task 2: Add verification function]

You: Let me request code review before proceeding.

BASE_SHA=$(git log --oneline | grep "Task 1" | head -1 | cut -d' ' -f1)
HEAD_SHA=$(git rev-parse HEAD)

[Dispatch code reviewer subagent]
  DESCRIPTION: Added verifyIndex() and repairIndex() with 4 issue types
  PLAN_OR_REQUIREMENTS: Task 2 from docs/superpowers/plans/deployment-plan.md
  BASE_SHA: a7981ec
  HEAD_SHA: 3df7661

[Subagent returns]:
  Strengths: Clean architecture, real tests
  Issues:
    Important: Missing progress indicators
    Minor: Magic number (100) for reporting interval
  Assessment: Ready to proceed

You: [Fix progress indicators]
[Continue to Task 3]

Common Rationalizations

ExcuseReality
"I'll just review the diff myself instead of dispatching a reviewer"You're the coordinator — reviewing the diff inline burns the context window you need to keep driving the work. Dispatch a reviewer subagent: the diff and the evaluation live in its context, and only the findings come back to you.
"The reviewer needs my whole session history to understand the change"Hand it precisely crafted context, never your session's history. That keeps the reviewer on the work product, not your thought process.

Red Flags

Never:

If reviewer wrong:

See template at: code-reviewer.md

同类技能
brainstormingdispatching-parallel-agentsexecuting-plansfinishing-a-development-branchreceiving-code-reviewsubagent-driven-developmentsystematic-debuggingusing-git-worktrees
本页内容来自开源项目 obra, 版权归原作者所有。
本站仅作技能索引与分享,所有 Skill 版权归其原作者所有。